Issue 1160973002: Revert 'Revert to use macro REG_MASK_BIT, now with parentheses.'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1160973002: Revert 'Revert to use macro REG_MASK_BIT, now with parentheses.' (Closed)

Created:
5 years, 6 months ago by koda

Modified:
5 years, 6 months ago

Reviewers:

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Revert 'Revert to use macro REG_MASK_BIT, now with parentheses.' Turns out some compilers are allergic to negative shifts, even if it will obviously not be executed. BUG= Committed: https://github.com/dart-lang/sdk/commit/74d511396e03919952231274383f7bd5f6a99d7b

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -9 lines)			Patch
	M	runtime/vm/flow_graph_compiler.cc	View		2 chunks	+13 lines, -9 lines	0 comments	Download

Total messages: 1 (0 generated)

koda

5 years, 6 months ago (2015-05-28 20:24:07 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
74d511396e03919952231274383f7bd5f6a99d7b (presubmit successful).