Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1160963002: Use kSmiBits rather than #ifdef to define hash map constant. (Closed)

Created:
5 years, 6 months ago by koda
Modified:
5 years, 6 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use kSmiBits rather than #ifdef to define hash map constant. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/bf8ccee760a7c4e86de1458f9ebead5aad71ad31

Patch Set 1 #

Patch Set 2 : Ready to submit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M runtime/vm/object.cc View 1 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
koda
5 years, 6 months ago (2015-05-28 20:20:07 UTC) #2
siva
lgtm
5 years, 6 months ago (2015-05-28 20:34:34 UTC) #3
koda
5 years, 6 months ago (2015-06-02 13:00:40 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
bf8ccee760a7c4e86de1458f9ebead5aad71ad31 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698