Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1160943002: Give structured information about imports and export in the service's library response. (Closed)

Created:
5 years, 6 months ago by rmacnak
Modified:
5 years, 6 months ago
Reviewers:
turnidge, Cutch
CC:
reviews_dartlang.org, turnidge, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Give structured information about imports and export in the service's library response. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/2764bcefba01d8496704d43148404ff304355eaa

Patch Set 1 #

Patch Set 2 : add test #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -16 lines) Patch
M runtime/observatory/lib/src/elements/library_view.html View 1 chunk +5 lines, -5 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 2 chunks +21 lines, -3 lines 0 comments Download
M runtime/observatory/tests/service/get_object_rpc_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A runtime/observatory/tests/service/library_dependency_test.dart View 1 1 chunk +42 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 1 chunk +59 lines, -5 lines 0 comments Download
M runtime/vm/service/service.md View 1 2 chunks +19 lines, -1 line 1 comment Download

Messages

Total messages: 6 (1 generated)
rmacnak
5 years, 6 months ago (2015-05-28 17:59:44 UTC) #2
Cutch
LGTM after adding a test that checks isImport, isExport, and isDeferred.
5 years, 6 months ago (2015-05-28 18:17:31 UTC) #3
rmacnak
On 2015/05/28 18:17:31, Cutch wrote: > LGTM after adding a test that checks isImport, isExport, ...
5 years, 6 months ago (2015-05-28 18:37:07 UTC) #4
rmacnak
Committed patchset #2 (id:20001) manually as 2764bcefba01d8496704d43148404ff304355eaa (presubmit successful).
5 years, 6 months ago (2015-05-28 18:37:26 UTC) #5
turnidge
5 years, 6 months ago (2015-05-28 20:10:28 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1160943002/diff/20001/runtime/vm/service/serv...
File runtime/vm/service/service.md (right):

https://codereview.chromium.org/1160943002/diff/20001/runtime/vm/service/serv...
runtime/vm/service/service.md:1319: class LibraryDependency {
Note for future reviews... Each type has its own ### section and is added to the
TOC.

I'm updating this in my current cl...

Powered by Google App Engine
This is Rietveld 408576698