Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1160903002: Revert "Change RangeError instances to use RangeError.range." (Closed)

Created:
5 years, 6 months ago by Lasse Reichstein Nielsen
Modified:
5 years, 6 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Change RangeError instances to use RangeError.range." Method hashes needs to be updated. Committed: https://github.com/dart-lang/sdk/commit/9e175d27d72b9346a7f607e31bd945c3df8ae680

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -138 lines) Patch
M runtime/lib/typed_data.dart View 76 chunks +120 lines, -109 lines 0 comments Download
M runtime/vm/exceptions.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/exceptions.cc View 2 chunks +10 lines, -11 lines 0 comments Download
M runtime/vm/symbols.h View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/js_lib/native_typed_data.dart View 3 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Lasse Reichstein Nielsen
Committed patchset #1 (id:1) manually as 9e175d27d72b9346a7f607e31bd945c3df8ae680 (presubmit successful).
5 years, 6 months ago (2015-05-28 08:46:20 UTC) #1
Lasse Reichstein Nielsen
TBR.
5 years, 6 months ago (2015-05-28 08:47:53 UTC) #3
Søren Gjesse
5 years, 6 months ago (2015-05-28 08:59:45 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698