Only units with 'part of' and no other directives are parts.

Only units with 'part of' and no other directives are parts.

Invalidate CONTAINING_LIBRARIES as needed.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/32f4b9aca57867104fceb512bf32ed9af02682bd

[Brian Wilkerson, 2015-06-04 20:45:57]

https://codereview.chromium.org/1160873004/diff/1/pkg/analyzer/lib/src/task/d...
File pkg/analyzer/lib/src/task/dart_work_manager.dart (right):

https://codereview.chromium.org/1160873004/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart_work_manager.dart:346:
_invalidateContainingLibraries(part);
I think this does too much. If a file 'part.dart' is included (via part
directive) in both 'libA.dart' and 'libB.dart', and 'libA.dart' is modified,
won't we loose the fact that 'part.dart' is in 'libB.dart'?

[scheglov, 2015-06-04 20:50:28]

https://codereview.chromium.org/1160873004/diff/1/pkg/analyzer/lib/src/task/d...
File pkg/analyzer/lib/src/task/dart_work_manager.dart (right):

https://codereview.chromium.org/1160873004/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart_work_manager.dart:346:
_invalidateContainingLibraries(part);
On 2015/06/04 20:45:56, Brian Wilkerson wrote:
> I think this does too much. If a file 'part.dart' is included (via part
> directive) in both 'libA.dart' and 'libB.dart', and 'libA.dart' is modified,
> won't we loose the fact that 'part.dart' is in 'libB.dart'?

Yes, we will lose it in the cache.
So, ContainingLibrariesTask will be run, call context.getLibrariesContaining()
and get this information again into cache by asking DartWorkManager.

We don't nuke this information in DartWorkManager, so "part.dart" will remember
that it is a part of "libB.dart".

[Brian Wilkerson, 2015-06-04 20:57:48]

LGTM

[scheglov, 2015-06-04 21:03:13]

Committed patchset #1 (id:1) manually as
32f4b9aca57867104fceb512bf32ed9af02682bd (presubmit successful).