Resolve the executable path on Mac OS when sym-linked

Resolve the executable path on Mac OS when sym-linked

Also resolve its directory if symlinked.

This helps to locate the Dart SDK (if any) from the path of the dart
executable. On Linux the use of /proc/self/exe already takes care of this.

R=kustermann@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/d5a34bd6d2bf3c05023214e1cf387943929b56d4

[kustermann, 2015-06-08 08:22:26]

https://codereview.chromium.org/1160793004/diff/1/runtime/bin/platform_macos.cc
File runtime/bin/platform_macos.cc (right):

https://codereview.chromium.org/1160793004/diff/1/runtime/bin/platform_macos....
runtime/bin/platform_macos.cc:121: }
So this only handles symlinks to the binary itself or it's directory (which is
bin), but not to the sdk directory?

Furthermore it doesn't seem to handle symlinks to symlinks to actual binaries if
I see this correctly.

Can't you just use the File::GetCanonicalPath() function defined in this file?
The manpage indicates that it will resolve all '.' '..' and symlinks.

[Søren Gjesse, 2015-06-09 10:46:48]

PTAL

https://codereview.chromium.org/1160793004/diff/1/runtime/bin/platform_macos.cc
File runtime/bin/platform_macos.cc (right):

https://codereview.chromium.org/1160793004/diff/1/runtime/bin/platform_macos....
runtime/bin/platform_macos.cc:121: }
On 2015/06/08 08:22:25, kustermann wrote:
> So this only handles symlinks to the binary itself or it's directory (which is
> bin), but not to the sdk directory?
> 
> Furthermore it doesn't seem to handle symlinks to symlinks to actual binaries
if
> I see this correctly.
> 
> Can't you just use the File::GetCanonicalPath() function defined in this file?
> The manpage indicates that it will resolve all '.' '..' and symlinks.

Thanks Martin. This was a really crappy attempt to partly implement realpath.

[kustermann, 2015-06-09 10:49:47]

LGTM

https://codereview.chromium.org/1160793004/diff/20001/runtime/bin/platform_ma...
File runtime/bin/platform_macos.cc (right):

https://codereview.chromium.org/1160793004/diff/20001/runtime/bin/platform_ma...
runtime/bin/platform_macos.cc:95: // Return the canonnical path as the returned
path might contain sym-links.
sym-links -> symlinks

canonnical -> canonical

[Søren Gjesse, 2015-06-09 14:13:07]

Committed patchset #3 (id:40001) manually as
d5a34bd6d2bf3c05023214e1cf387943929b56d4 (presubmit successful).

[nweiz, 2015-06-09 19:12:49]

On 2015/06/09 14:13:07, Søren Gjesse wrote:
> Committed patchset #3 (id:40001) manually as
> d5a34bd6d2bf3c05023214e1cf387943929b56d4 (presubmit successful).

Can we cherry-pick this into trunk?