Issue 1160623004: Fix build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1160623004: Fix build (Closed)

Created:
5 years, 6 months ago by srdjan

Modified:
5 years, 6 months ago

Reviewers:
koda

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix build BUG= Committed: https://github.com/dart-lang/sdk/commit/12da412110a776630b50def37401148ccce250e3

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	runtime/lib/double.cc	View		1 chunk	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

srdjan

Committed patchset #1 (id:1) manually as 12da412110a776630b50def37401148ccce250e3 (presubmit successful).

5 years, 6 months ago (2015-06-03 18:24:43 UTC) #3

koda

On 2015/06/03 18:24:43, srdjan wrote: > Committed patchset #1 (id:1) manually as > 12da412110a776630b50def37401148ccce250e3 (presubmit ...

5 years, 6 months ago (2015-06-03 18:37:21 UTC) #4

srdjan

5 years, 6 months ago (2015-06-03 19:36:19 UTC) #5

Message was sent while issue was closed.

On 2015/06/03 18:37:21, koda wrote:
> On 2015/06/03 18:24:43, srdjan wrote:
> > Committed patchset #1 (id:1) manually as
> > 12da412110a776630b50def37401148ccce250e3 (presubmit successful).
> 
> Consider using bit_cast from globals.h

Yes, that is the one I was looking for.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages