Issue 11606021: Fixing selectoptions test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11606021: Fixing selectoptions test. (Closed)

Created:
8 years ago by blois

Modified:
8 years ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixing htmlcollectionoptions test to behave the same on all platforms. Basically the options collection had different behavior between dartium and dart2js because of some polyfill limitations. I've unified the behavior. BUG=3813 Committed: https://code.google.com/p/dart/source/detail?r=16301

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -41 lines)			Patch
M	sdk/lib/html/dartium/html_dartium.dart	View	4 chunks	+15 lines, -10 lines	0 comments	Download
M	sdk/lib/html/scripts/htmlrenamer.py	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	sdk/lib/html/scripts/systemhtml.py	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	sdk/lib/html/templates/html/dart2js/impl_HTMLSelectElement.darttemplate	View	1 chunk	+0 lines, -25 lines	0 comments	Download
A +	sdk/lib/html/templates/html/impl/impl_HTMLSelectElement.darttemplate	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	tests/html/html.status	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	tests/html/htmloptionscollection_test.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages