Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 11606020: Reapply "Fixes to eventhandler and HTTP"" (Closed)

Created:
8 years ago by Søren Gjesse
Modified:
8 years ago
Reviewers:
Mads Ager (google)
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Reapply "Fixes to eventhandler and HTTP"" This reapplies r16252 with a number of fixes. R=ager@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=16306

Patch Set 1 #

Patch Set 2 : Add changes missing in r16252 #

Patch Set 3 : Correct error check (fixes Mac OS failure) #

Patch Set 4 : Remove invalid assert (fixes Windows test) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -62 lines) Patch
M runtime/bin/eventhandler_win.h View 3 chunks +5 lines, -1 line 0 comments Download
M runtime/bin/eventhandler_win.cc View 7 chunks +54 lines, -40 lines 0 comments Download
M runtime/bin/socket.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/socket_patch.dart View 1 3 chunks +8 lines, -4 lines 0 comments Download
M sdk/lib/io/http_impl.dart View 1 2 3 4 chunks +7 lines, -5 lines 0 comments Download
M sdk/lib/io/http_parser.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/io/socket_stream_impl.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/standalone/io/http_shutdown_test.dart View 4 chunks +13 lines, -4 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Gjesse
The exact changes to the original commit is documented as separate patches.
8 years ago (2012-12-18 14:58:38 UTC) #1
Mads Ager (google)
8 years ago (2012-12-18 15:15:58 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698