Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 1160543003: Ignore not existing parts. (Closed)

Created:
5 years, 6 months ago by scheglov
Modified:
5 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Ignore not existing parts. We decided to produce an empty token streams, so empty units for them. So, we need to have a separate check for not existing Source later. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/250992aad8ad1d42d9758e770502193ff56b1c21

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M pkg/analyzer/lib/src/task/dart.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 6 months ago (2015-06-02 18:01:22 UTC) #1
Brian Wilkerson
LGTM
5 years, 6 months ago (2015-06-02 18:05:11 UTC) #2
scheglov
5 years, 6 months ago (2015-06-02 18:09:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
250992aad8ad1d42d9758e770502193ff56b1c21 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698