Issue 1160513002: TEMPORARY - Validate fix for 16994 with some caveats

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1160513002: TEMPORARY - Validate fix for 16994 with some caveats (Closed)

Created:
5 years, 7 months ago by kevmoo

Modified:
5 years, 6 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

TEMPORARY - Validate fix for 16994 with some caveats Committed: https://github.com/dart-lang/sdk/commit/52f9548d5806971187af54ce9f861736e6b454f6

Patch Set 1 #

Total comments: 1

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+126 lines, -9 lines)			Patch
	A +	tests/standalone/io/platform_executable_script.dart	View		1 chunk	+2 lines, -9 lines	0 comments	Download
	A	tests/standalone/io/platform_executable_test.dart	View		1 chunk	+124 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

kevmoo

Committed patchset #1 (id:1) manually as 52f9548d5806971187af54ce9f861736e6b454f6 (presubmit successful).

5 years, 7 months ago (2015-05-25 03:00:15 UTC) #3

Søren Gjesse

5 years, 6 months ago (2015-05-26 15:30:00 UTC) #4

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/1160513002/diff/1/tests/standalone/io/platfor...
File tests/standalone/io/platform_executable_test.dart (right):

https://codereview.chromium.org/1160513002/diff/1/tests/standalone/io/platfor...
tests/standalone/io/platform_executable_test.dart:39: print('*** Running
normally');
Remove debug print?

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages