Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 1160423002: Fix signature of UnmodifiableListMixin.insert to match List.insert. (Closed)

Created:
5 years, 6 months ago by Anders Johnsen
Modified:
5 years, 6 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix signature of UnmodifiableListMixin.insert to match List.insert. BUG= R=lrn@google.com Committed: https://github.com/dart-lang/sdk/commit/114c37738d20efaa5ec4697581bd9aa298ea137d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M sdk/lib/internal/list.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Anders Johnsen
5 years, 6 months ago (2015-06-03 07:29:08 UTC) #2
Lasse Reichstein Nielsen
lgtm
5 years, 6 months ago (2015-06-03 07:30:42 UTC) #3
Anders Johnsen
5 years, 6 months ago (2015-06-03 07:32:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
114c37738d20efaa5ec4697581bd9aa298ea137d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698