Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1160383002: update_homebrew: support version-formatted revisions (Closed)

Created:
5 years, 6 months ago by kevmoo
Modified:
5 years, 6 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org, ricow1
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

update_homebrew: support version-formatted revisions fix for running in checked mode R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/856248f1356d1e7564c8b27dcbe35c770cde2eb5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M tools/apps/update_homebrew/bin/update_homebrew.dart View 4 chunks +14 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
kevmoo
5 years, 6 months ago (2015-06-01 22:46:08 UTC) #2
Bill Hesse
lgtm
5 years, 6 months ago (2015-06-02 08:36:29 UTC) #3
Bill Hesse
I tried running this to update the stable channel, and it failed, with an error ...
5 years, 6 months ago (2015-06-02 16:14:07 UTC) #4
kevmoo
Committed patchset #1 (id:1) manually as 856248f1356d1e7564c8b27dcbe35c770cde2eb5 (presubmit successful).
5 years, 6 months ago (2015-06-02 17:02:16 UTC) #5
Bill Hesse
5 years, 6 months ago (2015-06-03 09:26:26 UTC) #6
Message was sent while issue was closed.
On 2015/06/02 16:14:07, Bill Hesse wrote:
> I tried running this to update the stable channel, and it failed, with an
error
> I could not debug.  I had patched this in to tot, and run pub get.
> 
> I reverted to the version of update-homebrew before the async-await change,
and
> patched in this change, and was able to run it, updating stable to r45692.
> 
> Please check that the app works now, before (or after) committing this change.

> This change seems right, though.

This failure was due to my installed dart version being out of date (Version
1.9).  When I updated my dart executable, it worked.

Powered by Google App Engine
This is Rietveld 408576698