Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1160313006: Revert "Refactoring resolution of local access and unqualified access of statics" (Closed)

Created:
5 years, 6 months ago by Johnni Winther
Modified:
5 years, 6 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Refactoring resolution of local access and unqualified access of statics" This reverts commit 58896b74ce50615114a006282e5b353885eca385. BUG= Committed: https://github.com/dart-lang/sdk/commit/1807369aa14f16bdcf0f23fc7d0091d04dbdd1f9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -496 lines) Patch
M pkg/compiler/lib/src/enqueue.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/helpers/trace.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart View 2 chunks +0 lines, -36 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 16 chunks +35 lines, -370 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution_common.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 6 chunks +12 lines, -58 lines 0 comments Download
M tests/compiler/dart2js/diagnose_ambiguous_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/resolver_test.dart View 5 chunks +18 lines, -10 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test_send_data.dart View 4 chunks +8 lines, -9 lines 0 comments Download
M tests/compiler/dart2js/simple_inferrer_test.dart View 3 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
TBR
5 years, 6 months ago (2015-06-08 10:54:01 UTC) #2
Johnni Winther
Committed patchset #1 (id:1) manually as 1807369aa14f16bdcf0f23fc7d0091d04dbdd1f9 (presubmit successful).
5 years, 6 months ago (2015-06-08 10:55:34 UTC) #3
karlklose
5 years, 6 months ago (2015-06-08 10:58:18 UTC) #4
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698