Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 1160153002: Support implicit super constructor invocation in SemanticDeclarationVisitor. (Closed)

Created:
5 years, 6 months ago by Johnni Winther
Modified:
5 years, 6 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support implicit super constructor invocation in SemanticDeclarationVisitor. BUG= R=ajohnsen@google.com, karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/a6bbcc3c87e6ae4f46988292ea7909774bdbd056

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+210 lines, -80 lines) Patch
M pkg/compiler/lib/src/constants/constructors.dart View 5 chunks +32 lines, -29 lines 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor.dart View 6 chunks +29 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart View 9 chunks +29 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/resolution/send_resolver.dart View 1 chunk +33 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/send_structure.dart View 1 chunk +43 lines, -13 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test.dart View 13 chunks +44 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
5 years, 6 months ago (2015-05-29 10:54:08 UTC) #2
karlklose
LGTM.
5 years, 6 months ago (2015-05-29 11:16:10 UTC) #3
Anders Johnsen
LGTM, thank you!
5 years, 6 months ago (2015-05-29 11:17:10 UTC) #4
Johnni Winther
5 years, 6 months ago (2015-05-29 12:50:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a6bbcc3c87e6ae4f46988292ea7909774bdbd056 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698