Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1160063002: Remove unused pc descriptor types. (Closed)

Created:
5 years, 6 months ago by Florian Schneider
Modified:
5 years, 6 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove unused pc descriptor types. kClosureCall and kOptStaticCall are not needed anymore. Closure calls are implemented as instance calls - the ClosureCall instruction only occurs in the synthetic FunctionImpl.call dispatcher - and does not correspond to a source location where breakpoints can be set. kOptStaticCall is not needed because breakpoints can only be set in unoptimized code. kOther is used instead. This also removes an unused PC descriptor at closure calls from unoptimized code. BUG= R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/e0621416f85ddd857b84f0f5abbd8a5d69be9cf3

Patch Set 1 #

Patch Set 2 : removed dead stub code #

Patch Set 3 : remove kOptStaticCall #

Total comments: 2

Patch Set 4 : added comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -188 lines) Patch
M runtime/vm/debugger.cc View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M runtime/vm/debugger_arm.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/vm/debugger_arm64.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/vm/debugger_ia32.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M runtime/vm/debugger_mips.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/vm/debugger_x64.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm64.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 2 3 1 chunk +6 lines, -9 lines 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 1 2 3 1 chunk +6 lines, -9 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 2 3 1 chunk +6 lines, -9 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 2 3 1 chunk +6 lines, -9 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 2 3 1 chunk +6 lines, -9 lines 0 comments Download
M runtime/vm/object.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/raw_object.h View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M runtime/vm/stub_code.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/stub_code_arm.cc View 1 1 chunk +0 lines, -15 lines 0 comments Download
M runtime/vm/stub_code_arm64.cc View 1 1 chunk +0 lines, -17 lines 0 comments Download
M runtime/vm/stub_code_ia32.cc View 1 1 chunk +0 lines, -22 lines 0 comments Download
M runtime/vm/stub_code_mips.cc View 1 1 chunk +0 lines, -23 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 1 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Florian Schneider
5 years, 6 months ago (2015-05-28 12:10:48 UTC) #2
Vyacheslav Egorov (Google)
LGTM https://codereview.chromium.org/1160063002/diff/40001/runtime/vm/intermediate_language_arm.cc File runtime/vm/intermediate_language_arm.cc (right): https://codereview.chromium.org/1160063002/diff/40001/runtime/vm/intermediate_language_arm.cc#newcode238 runtime/vm/intermediate_language_arm.cc:238: compiler->AddCurrentDescriptor(RawPcDescriptors::kDeopt, Add a comment about !is_optimizing() case because ...
5 years, 6 months ago (2015-05-28 12:19:35 UTC) #3
Florian Schneider
https://codereview.chromium.org/1160063002/diff/40001/runtime/vm/intermediate_language_arm.cc File runtime/vm/intermediate_language_arm.cc (right): https://codereview.chromium.org/1160063002/diff/40001/runtime/vm/intermediate_language_arm.cc#newcode238 runtime/vm/intermediate_language_arm.cc:238: compiler->AddCurrentDescriptor(RawPcDescriptors::kDeopt, On 2015/05/28 12:19:35, Vyacheslav Egorov (Google) wrote: > ...
5 years, 6 months ago (2015-05-28 12:25:21 UTC) #4
Florian Schneider
5 years, 6 months ago (2015-05-28 12:27:43 UTC) #5
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
e0621416f85ddd857b84f0f5abbd8a5d69be9cf3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698