Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1159983005: - Update expected string in pub test. (Closed)

Created:
5 years, 6 months ago by Ivan Posva
Modified:
5 years, 6 months ago
Reviewers:
ricow1, nweiz, siva, Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

- Update expected string in pub test. BUG= Committed: https://github.com/dart-lang/sdk/commit/91e71b53e3e042d9190ccbd938fa18d4040bab8c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M sdk/lib/_internal/pub/test/transformer/fails_to_load_a_transform_with_an_import_error_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Ivan Posva
TBR
5 years, 6 months ago (2015-05-28 07:32:09 UTC) #2
Ivan Posva
Committed patchset #1 (id:1) manually as 91e71b53e3e042d9190ccbd938fa18d4040bab8c (presubmit successful).
5 years, 6 months ago (2015-05-28 07:32:35 UTC) #3
ricow1
lgtm
5 years, 6 months ago (2015-05-28 07:32:50 UTC) #4
ricow1
+Bob, +Natalie fyi
5 years, 6 months ago (2015-05-28 07:33:33 UTC) #6
Bob Nystrom
5 years, 6 months ago (2015-05-28 16:19:58 UTC) #7
Message was sent while issue was closed.
LGTM. Thanks for updating this!

We try to avoid asserting based on exception strings, but sometimes it's the
best option.

Powered by Google App Engine
This is Rietveld 408576698