Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1159923010: Use the Zone API for registerException. (Closed)

Created:
5 years, 6 months ago by nweiz
Modified:
5 years, 6 months ago
Reviewers:
Bob Nystrom, kevmoo
CC:
reviews_dartlang.org, kevmoo
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : more changes #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -17 lines) Patch
M CHANGELOG.md View 1 1 chunk +5 lines, -0 lines 2 comments Download
M lib/src/backend/invoker.dart View 1 5 chunks +5 lines, -8 lines 0 comments Download
M lib/src/frontend/expect_async.dart View 1 4 chunks +8 lines, -3 lines 0 comments Download
M lib/src/frontend/future_matchers.dart View 1 1 chunk +1 line, -4 lines 0 comments Download
M lib/test.dart View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
nweiz
5 years, 6 months ago (2015-05-29 00:04:24 UTC) #1
kevmoo
lgtm
5 years, 6 months ago (2015-05-29 20:11:07 UTC) #3
nweiz
I just added some changes to more thoroughly pass exceptions through zones; PTAL
5 years, 6 months ago (2015-05-29 20:30:16 UTC) #4
kevmoo
LGTM w/ comment https://codereview.chromium.org/1159923010/diff/20001/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/1159923010/diff/20001/CHANGELOG.md#newcode4 CHANGELOG.md:4: the Zone API. Do we that ...
5 years, 6 months ago (2015-05-29 20:51:16 UTC) #5
nweiz
https://codereview.chromium.org/1159923010/diff/20001/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/1159923010/diff/20001/CHANGELOG.md#newcode4 CHANGELOG.md:4: the Zone API. On 2015/05/29 20:51:16, kevmoo wrote: > ...
5 years, 6 months ago (2015-05-29 20:53:39 UTC) #6
nweiz
5 years, 6 months ago (2015-05-29 20:54:50 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
3c82e4642cba4c195638c5ffa8f0864d6a3c9bb9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698