Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 1159783004: Misc Observatory patches: (Closed)

Created:
5 years, 6 months ago by rmacnak
Modified:
5 years, 6 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Misc Observatory patches: - Address some editor hints. - Place eval box above fields and be much more generous in expanding fields. - Treat maps as plain instances so their refs aren't blank. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/98999e6a0210ef601b2c7a4c9971535e11379387

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -32 lines) Patch
M runtime/observatory/lib/src/elements/class_view.dart View 1 2 1 chunk +8 lines, -3 lines 0 comments Download
M runtime/observatory/lib/src/elements/class_view.html View 2 chunks +8 lines, -3 lines 0 comments Download
M runtime/observatory/lib/src/elements/heap_snapshot.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/instance_ref.html View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/instance_view.html View 3 chunks +8 lines, -7 lines 0 comments Download
M runtime/observatory/lib/src/elements/isolate_view.html View 1 2 1 chunk +6 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/elements/library_view.dart View 1 chunk +8 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/library_view.html View 2 chunks +6 lines, -5 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/observatory/tests/service/break_on_activation_test.dart View 4 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
rmacnak
5 years, 6 months ago (2015-06-01 21:21:07 UTC) #2
Cutch
lgtm
5 years, 6 months ago (2015-06-01 21:26:00 UTC) #3
rmacnak
5 years, 6 months ago (2015-06-01 21:59:59 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
98999e6a0210ef601b2c7a4c9971535e11379387 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698