Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 11596002: Changed the test a bit to ensure dart:io is not included as dartium cannot import dart:io (Closed)

Created:
8 years ago by siva
Modified:
8 years ago
Reviewers:
Tom Ball
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Changed the test a bit to ensure dart:io is not included as dartium cannot import dart:io Committed: https://code.google.com/p/dart/source/detail?r=16200

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -39 lines) Patch
M tests/vm/dart/isolate_unhandled_exception_test.dart View 3 chunks +4 lines, -12 lines 0 comments Download
M tests/vm/dart/isolate_unhandled_exception_test2.dart View 3 chunks +5 lines, -12 lines 0 comments Download
M tests/vm/dart/isolate_unhandled_exception_uri_helper.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/vm/dart/isolate_unhandled_exception_uri_test.dart View 2 chunks +4 lines, -15 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
siva
TBR
8 years ago (2012-12-15 20:36:01 UTC) #1
Tom Ball
8 years ago (2012-12-15 20:42:01 UTC) #2
lgtm -- I obviously have a lot more to learn about Dart testing.

Powered by Google App Engine
This is Rietveld 408576698