Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 11595007: Revert "Mirrors implemented via patches." (Closed)

Created:
8 years ago by Johnni Winther
Modified:
8 years ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Mirrors implemented via patches." This reverts commit r16204, 16206, and r16210. Committed: https://code.google.com/p/dart/source/detail?r=16211

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+751 lines, -866 lines) Patch
D runtime/lib/mirrors_patch.dart View 1 chunk +0 lines, -28 lines 0 comments Download
M runtime/lib/mirrors_sources.gypi View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/compiler.dart View 2 chunks +3 lines, -1 line 0 comments Download
A + sdk/lib/_internal/compiler/implementation/lib/mirrors.dart View 1 chunk +18 lines, -14 lines 0 comments Download
D sdk/lib/_internal/compiler/implementation/lib/mirrors_patch.dart View 1 chunk +0 lines, -92 lines 0 comments Download
M sdk/lib/_internal/libraries.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/mirrors/mirrors.dart View 1 chunk +727 lines, -3 lines 0 comments Download
D sdk/lib/mirrors/mirrors_impl.dart View 1 chunk +0 lines, -725 lines 0 comments Download
M sdk/lib/mirrors/mirrors_sources.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Johnni Winther
TBR
8 years ago (2012-12-17 14:57:27 UTC) #1
ahe
8 years ago (2012-12-17 15:39:47 UTC) #2
Message was sent while issue was closed.
LGTM :-(

Powered by Google App Engine
This is Rietveld 408576698