Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 11591015: Mirrors implemented via patches. (Closed)

Created:
8 years ago by Johnni Winther
Modified:
8 years ago
CC:
reviews_dartlang.org, turnidge, ahe
Visibility:
Public.

Description

Mirrors implemented via patches. Committed: https://code.google.com/p/dart/source/detail?r=16204

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -866 lines) Patch
A runtime/lib/mirrors_patch.dart View 1 chunk +28 lines, -0 lines 0 comments Download
M runtime/lib/mirrors_sources.gypi View 1 chunk +1 line, -1 line 0 comments Download
D sdk/lib/_internal/compiler/implementation/lib/mirrors.dart View 1 chunk +0 lines, -96 lines 0 comments Download
A + sdk/lib/_internal/compiler/implementation/lib/mirrors_patch.dart View 1 chunk +14 lines, -16 lines 0 comments Download
M sdk/lib/_internal/libraries.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/mirrors/mirrors.dart View 1 chunk +2 lines, -728 lines 0 comments Download
A + sdk/lib/mirrors/mirrors_impl.dart View 3 chunks +3 lines, -23 lines 0 comments Download
M sdk/lib/mirrors/mirrors_sources.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Johnni Winther
8 years ago (2012-12-17 13:03:30 UTC) #1
Anders Johnsen
LGTM
8 years ago (2012-12-17 13:10:09 UTC) #2
Mads Ager (google)
8 years ago (2012-12-17 13:12:56 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698