Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1159073004: Move analyzer_cli out of pkg_tested. (Closed)

Created:
5 years, 6 months ago by pquitslund
Modified:
5 years, 6 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move analyzer_cli out of pkg_tested. Net-net: we used `mockito` for testing and that's not in `third_party`. Until it is (or we remove the need for it), we need to get out of `pkg_tested`. R=paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/fcc694c62918576cefb5c330d3830584a72ca2a5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
pquitslund
5 years, 6 months ago (2015-06-03 20:42:29 UTC) #2
Paul Berry
lgtm assuming this is a short-term fix.
5 years, 6 months ago (2015-06-03 20:45:13 UTC) #3
pquitslund
5 years, 6 months ago (2015-06-03 20:46:40 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fcc694c62918576cefb5c330d3830584a72ca2a5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698