Issue 1158863002: Mark script kinds as private in the service protocol.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1158863002: Mark script kinds as private in the service protocol. (Closed)

Created:
5 years, 7 months ago by rmacnak

Modified:
5 years, 7 months ago

Reviewers:
turnidge, Cutch

CC:
reviews_dartlang.org, turnidge, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -33 lines)			Patch
M	runtime/observatory/lib/src/service/object.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/observatory/tests/service/get_object_rpc_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/coverage_test.cc	View	1	4 chunks	+4 lines, -4 lines	0 comments	Download
M	runtime/vm/debugger_test.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/object.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/report_test.cc	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/service/service.md	View	1	3 chunks	+0 lines, -21 lines	0 comments	Download

Total messages: 5 (1 generated)

Cutch

On 2015/05/26 23:18:10, rmacnak wrote: Can we hold off on this until I land my ...

5 years, 7 months ago (2015-05-26 23:20:12 UTC) #3

rmacnak

5 years, 7 months ago (2015-05-27 16:28:24 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
dfee2bf45d7fa5701476f95b195276e4479198a3 (presubmit successful).