Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1158793004: Add isExternal accessor to element model (Closed)

Created:
5 years, 6 months ago by Brian Wilkerson
Modified:
5 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -17 lines) Patch
M pkg/analyzer/lib/src/generated/element.dart View 8 chunks +43 lines, -17 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element_handle.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 7 chunks +21 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 23 chunks +93 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
5 years, 6 months ago (2015-06-04 19:27:09 UTC) #2
scheglov
LGTM
5 years, 6 months ago (2015-06-04 19:37:19 UTC) #3
Brian Wilkerson
5 years, 6 months ago (2015-06-04 19:38:33 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
56be513cf9298258e0e1844c2f1682e78a7be848 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698