Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 1158743003: Fix test 'platform_executable_test' (Closed)

Created:
5 years, 7 months ago by Søren Gjesse
Modified:
5 years, 7 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix test 'platform_executable_test' If the PATH environmant variable is not passed when overriding the exnironment for a spawned process on Linux a default is used. From the man page for 'execvp': The file is sought in the colon-separated list of directory pathnames specified in the PATH environment variable. If this variable isn't defined, the path list defaults to the current directory followed by the list of directories returned by confstr(_CS_PATH). (This confstr(3) call typically returns the value "/bin:/usr/bin".) If one have Dart installed in e.g. /usr/bin the test would fail, as starting 'dart' would succeed. R=kevmoo@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/99e9842ccc8b129306852c17ed970773446c818b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M tests/standalone/io/platform_executable_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Gjesse
5 years, 7 months ago (2015-05-26 15:23:04 UTC) #1
kevmoo
LGTM – I was smoking something
5 years, 7 months ago (2015-05-26 19:02:01 UTC) #2
Søren Gjesse
5 years, 7 months ago (2015-05-27 07:58:54 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
99e9842ccc8b129306852c17ed970773446c818b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698