Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1158463003: Don't wrap exceptions in complete or completes(). (Closed)

Created:
5 years, 6 months ago by nweiz
Modified:
5 years, 6 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -24 lines) Patch
M CHANGELOG.md View 1 chunk +5 lines, -0 lines 0 comments Download
M lib/src/frontend/future_matchers.dart View 3 chunks +5 lines, -20 lines 0 comments Download
M test/frontend/matcher/completion_test.dart View 3 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 6 months ago (2015-05-29 21:37:54 UTC) #1
kevmoo
lgtm
5 years, 6 months ago (2015-05-29 22:05:16 UTC) #2
nweiz
5 years, 6 months ago (2015-05-29 23:18:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
028c4e182ee767f9fe5a5a7a8e1f01bbeda111a1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698