Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 1158453002: Allow `return;` in async method. (Closed)

Created:
5 years, 7 months ago by Johnni Winther
Modified:
5 years, 7 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allow `return;` in async method. BUG=http://dartbug.com/23200 R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/083dce756bf4c9fdebe89e0338c504665e7eac6f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M pkg/compiler/lib/src/typechecker.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/type_checker_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Johnni Winther
5 years, 7 months ago (2015-05-22 13:53:18 UTC) #2
kevmoo
On 2015/05/22 13:53:18, Johnni Winther wrote: DBC: is there a shared test that will cover ...
5 years, 7 months ago (2015-05-22 14:49:13 UTC) #3
floitsch
LGTM.
5 years, 7 months ago (2015-05-22 19:03:57 UTC) #4
Johnni Winther
On 2015/05/22 14:49:13, kevmoo wrote: > On 2015/05/22 13:53:18, Johnni Winther wrote: > > DBC: ...
5 years, 7 months ago (2015-05-25 10:46:22 UTC) #5
Johnni Winther
5 years, 7 months ago (2015-05-25 11:07:29 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
083dce756bf4c9fdebe89e0338c504665e7eac6f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698