Issue 1158423005: Move IS_INDEXABLE_FIELD to JsGetName.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1158423005: Move IS_INDEXABLE_FIELD to JsGetName. (Closed)

Created:
5 years, 6 months ago by karlklose

Modified:
5 years, 6 months ago

Reviewers:
herhut

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Move IS_INDEXABLE_FIELD to JsGetName. Also remove the old helper functions and references from js_helper and friends. R=herhut@google.com Committed: https://github.com/dart-lang/sdk/commit/183ae179583dd920af453f6f24cea0138f9e4b01

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -60 lines)			Patch
M	pkg/compiler/lib/src/js_backend/namer.dart	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/builder.dart	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	sdk/lib/_internal/compiler/js_lib/foreign_helper.dart	View	1 chunk	+0 lines, -47 lines	0 comments	Download
M	sdk/lib/_internal/compiler/js_lib/js_helper.dart	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	sdk/lib/_internal/compiler/js_lib/native_helper.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/js_lib/shared/embedded_names.dart	View	1 chunk	+16 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

karlklose

5 years, 6 months ago (2015-06-09 09:29:54 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
183ae179583dd920af453f6f24cea0138f9e4b01 (presubmit successful).