Issue 11583026: Add automatic initialization of SecureSocket library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11583026: Add automatic initialization of SecureSocket library. (Closed)

Created:
8 years ago by Bill Hesse

Modified:
8 years ago

Reviewers:
floitsch

CC:
reviews_dartlang.org, Søren Gjesse

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add automatic initialization of SecureSocket library. BUG=dart:7541 Committed: https://code.google.com/p/dart/source/detail?r=16384

Patch Set 1 #

Total comments: 1

Patch Set 2 : Change documentation to match code. #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -9 lines)			Patch
M	runtime/bin/secure_socket.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/bin/secure_socket.cc	View		3 chunks	+7 lines, -2 lines	0 comments	Download
M	sdk/lib/io/secure_socket.dart	View	1	3 chunks	+9 lines, -5 lines	0 comments	Download
M	tests/standalone/io/https_client_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

floitsch

8 years ago (2012-12-20 17:57:51 UTC) #2

LGTM.

https://codereview.chromium.org/11583026/diff/1/runtime/bin/secure_socket.cc
File runtime/bin/secure_socket.cc (right):

https://codereview.chromium.org/11583026/diff/1/runtime/bin/secure_socket.cc#...
runtime/bin/secure_socket.cc:370: mutex_.Unlock();  // MutexLocker destructor
not called when throwing.
The ... is not called ...

Expand Messages | Collapse Messages