Issue 1157823002: Send 'execution.launchData' only after full resolution.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1157823002: Send 'execution.launchData' only after full resolution. (Closed)

Created:
5 years, 7 months ago by scheglov

Modified:
5 years, 7 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Send 'execution.launchData' only after full resolution. We don't need to send them after each and every notice. This information becomes ready somewhere in between parsing and full resolution. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/45862f401e7cd3b6cdf39bdafe90d8d12f80ca02

Patch Set 1 #

Total comments: 1

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -2 lines)			Patch
	M	pkg/analysis_server/lib/src/domain_execution.dart	View		2 chunks	+10 lines, -2 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/1157823002/diff/1/pkg/analysis_server/lib/src/domain_execution.dart File pkg/analysis_server/lib/src/domain_execution.dart (right): https://codereview.chromium.org/1157823002/diff/1/pkg/analysis_server/lib/src/domain_execution.dart#newcode159 pkg/analysis_server/lib/src/domain_execution.dart:159: bool isHtmlFile = AnalysisEngine.isHtmlFileName(filePath); Why not "notice.resolvedHtmlUnit != ...

5 years, 7 months ago (2015-05-24 15:53:31 UTC) #2

scheglov

5 years, 7 months ago (2015-05-24 17:39:26 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
45862f401e7cd3b6cdf39bdafe90d8d12f80ca02 (presubmit successful).

Expand Messages | Collapse Messages