Issue 11578048: Make Platform.environment case-insensitive on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11578048: Make Platform.environment case-insensitive on Windows. (Closed)

Created:
8 years ago by Mads Ager (google)

Modified:
7 years, 11 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make Platform.environment case-insensitive on Windows. Environment variables on Windows are case-insensitive. In order to reliably be able to test if an environment variable is set and get its value, we therefore need to go case-insensitive. R=sgjesse@google.com BUG=dartbug.com/7454 Committed: https://code.google.com/p/dart/source/detail?r=16571

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -1 line)			Patch
M	sdk/lib/io/platform.dart	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	sdk/lib/io/platform_impl.dart	View	2 chunks	+34 lines, -1 line	0 comments	Download
M	tests/standalone/io/windows_environment_script.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM - sorry about the delay

Expand Messages | Collapse Messages