Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 11578029: Revert "Wat if you closure identical?" (Closed)

Created:
8 years ago by kasperl
Modified:
8 years ago
Reviewers:
ngeoffray
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Wat if you closure identical?" Revert "Update comment suggested by Kasper." This reverts r16112 and r16113. R=ngeoffray@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=16161

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -15 lines) Patch
M runtime/lib/identical_patch.dart View 1 chunk +3 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/core_patch.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 1 chunk +1 line, -1 line 0 comments Download
D tests/language/identical_closure_test.dart View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kasperl
8 years ago (2012-12-14 13:44:33 UTC) #1
kasperl
8 years ago (2012-12-14 13:45:03 UTC) #2
Message was sent while issue was closed.
TBR'ed to make it possible to run dart2js with assertions enabled.

Powered by Google App Engine
This is Rietveld 408576698