Issue 11578007: Turn on dartc testing of tests/standalone.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11578007: Turn on dartc testing of tests/standalone. (Closed)

Created:
8 years ago by Bill Hesse

Modified:
8 years ago

Reviewers:
Mads Ager (google), scheglov

CC:
reviews_dartlang.org, Mads Ager (google)

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Turn on dartc testing of tests/standalone. Fix a few remaining issues, and exclude the tests that are incompatible with dartc. BUG=dart:5064, dart:7066 Committed: https://code.google.com/p/dart/source/detail?r=16131

Patch Set 1 #

Total comments: 1

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+47 lines, -23 lines)			Patch
M	tests/standalone/io/dart_std_io_pipe_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/io/process_broken_pipe_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/io/process_check_arguments_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/io/process_environment_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/io/process_exit_negative_test.dart	View	1 chunk	+11 lines, -9 lines	1 comment	Download
M	tests/standalone/io/process_exit_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/io/process_kill_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/io/process_run_output_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/io/process_segfault_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/io/process_stderr_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/io/process_stdout_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/io/process_test_util.dart	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	tests/standalone/io/process_working_directory_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/io/read_into_const_list_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/io/test_runner_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/standalone.status	View	1 chunk	+19 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

8 years ago (2012-12-13 19:16:51 UTC) #3

Message was sent while issue was closed.

LGTM, thanks.

https://codereview.chromium.org/11578007/diff/1/tests/standalone/io/process_e...
File tests/standalone/io/process_exit_negative_test.dart (right):

https://codereview.chromium.org/11578007/diff/1/tests/standalone/io/process_e...
tests/standalone/io/process_exit_negative_test.dart:12: Future<Process> fp =
Process.start(getProcessTestFileName(),
Auch! Thanks Bill. :)

Expand Messages | Collapse Messages