Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 11578003: Handle timeouts in drt-trampoline on Windows. (Closed)

Created:
8 years ago by Mads Ager (google)
Modified:
8 years ago
Reviewers:
ricow1, kustermann
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Handle timeouts in drt-trampoline on Windows. This will make timeout of drt tests work on Windows. Killing dtr-trampoline did not kill DumpRenderTree on Windows. R=kustermann@google.com,ricow@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=16110

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -7 lines) Patch
M tools/testing/drt-trampoline.py View 1 1 chunk +18 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mads Ager (google)
8 years ago (2012-12-13 14:08:04 UTC) #1
kustermann
https://codereview.chromium.org/11578003/diff/1/tools/testing/drt-trampoline.py File tools/testing/drt-trampoline.py (right): https://codereview.chromium.org/11578003/diff/1/tools/testing/drt-trampoline.py#newcode101 tools/testing/drt-trampoline.py:101: version = ".".join(map(str, sys.version_info[:2])) I think "str" is not ...
8 years ago (2012-12-13 14:10:02 UTC) #2
kustermann
LGTM https://codereview.chromium.org/11578003/diff/1/tools/testing/drt-trampoline.py File tools/testing/drt-trampoline.py (right): https://codereview.chromium.org/11578003/diff/1/tools/testing/drt-trampoline.py#newcode101 tools/testing/drt-trampoline.py:101: version = ".".join(map(str, sys.version_info[:2])) On 2012/12/13 14:10:02, kustermann ...
8 years ago (2012-12-13 14:11:06 UTC) #3
Mads Ager (google)
Thanks Martin, I simplified the error message anyway.
8 years ago (2012-12-13 14:13:39 UTC) #4
ricow1
8 years ago (2012-12-13 14:17:26 UTC) #5
Message was sent while issue was closed.
LGTM, you could add more verbose error message stating that there might be
hanging processes

Powered by Google App Engine
This is Rietveld 408576698