Issue 11577003: Fix test now that we also go through an interceptor for operator[].

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11577003: Fix test now that we also go through an interceptor for operator[]. (Closed)

Created:
8 years ago by ngeoffray

Modified:
8 years ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix test now that we also go through an interceptor for operator[]. Committed: https://code.google.com/p/dart/source/detail?r=16101

Patch Set 1 #

Total comments: 3

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	tests/compiler/dart2js/type_inference_test.dart	View		3 chunks	+3 lines, -0 lines	3 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kasperl

8 years ago (2012-12-13 12:08:58 UTC) #2

Message was sent while issue was closed.

LGTM.

https://codereview.chromium.org/11577003/diff/1/tests/compiler/dart2js/type_i...
File tests/compiler/dart2js/type_inference_test.dart (right):

https://codereview.chromium.org/11577003/diff/1/tests/compiler/dart2js/type_i...
tests/compiler/dart2js/type_inference_test.dart:32: print([]);
Add comment: // Force a list to be instantiated.

https://codereview.chromium.org/11577003/diff/1/tests/compiler/dart2js/type_i...
tests/compiler/dart2js/type_inference_test.dart:53: print([]);
Ditto.

https://codereview.chromium.org/11577003/diff/1/tests/compiler/dart2js/type_i...
tests/compiler/dart2js/type_inference_test.dart:63: print([]);
Ditto.

Expand Messages | Collapse Messages