Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 11576060: Fixing up some Element and SvgElement tests to make them more platform-independent (Closed)

Created:
8 years ago by blois
Modified:
8 years ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Just cleaning up some tests to try to remove some exclusions and unnecessary failures because of acceptable platform differences. BUG= Committed: https://code.google.com/p/dart/source/detail?r=16404

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -22 lines) Patch
M tests/html/element_test.dart View 3 chunks +14 lines, -4 lines 0 comments Download
M tests/html/html.status View 5 chunks +1 line, -14 lines 0 comments Download
M tests/html/svgelement_test.dart View 3 chunks +14 lines, -4 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
blois
8 years ago (2012-12-18 17:56:26 UTC) #1
Emily Fortuna
https://codereview.chromium.org/11576060/diff/1004/tests/html/svgelement_test.dart File tests/html/svgelement_test.dart (right): https://codereview.chromium.org/11576060/diff/1004/tests/html/svgelement_test.dart#newcode173 tests/html/svgelement_test.dart:173: '<circle xmlns="http://www.w3.org/2000/svg" />' Is this something we could add ...
8 years ago (2012-12-18 18:47:15 UTC) #2
blois
https://codereview.chromium.org/11576060/diff/1004/tests/html/svgelement_test.dart File tests/html/svgelement_test.dart (right): https://codereview.chromium.org/11576060/diff/1004/tests/html/svgelement_test.dart#newcode173 tests/html/svgelement_test.dart:173: '<circle xmlns="http://www.w3.org/2000/svg" />' On 2012/12/18 18:47:15, Emily Fortuna wrote: ...
8 years ago (2012-12-18 20:50:04 UTC) #3
Emily Fortuna
8 years ago (2012-12-18 21:44:09 UTC) #4
okay. lgtm

Powered by Google App Engine
This is Rietveld 408576698