Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(898)

Issue 1157463003: Unsuppress animation tests on Chrome, they seem to have switched back to working (Closed)

Created:
5 years, 7 months ago by Alan Knight
Modified:
5 years, 7 months ago
Reviewers:
ricow1, Bill Hesse
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Unsuppress animation tests on Chrome, they seem to have switched back to working BUG= Committed: https://github.com/dart-lang/sdk/commit/6452961033268f4559aeca6a5f406899ba6c861b

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M tests/html/html.status View 1 chunk +2 lines, -6 lines 2 comments Download

Messages

Total messages: 6 (1 generated)
Alan Knight
TBR
5 years, 7 months ago (2015-05-21 21:05:25 UTC) #2
Alan Knight
Committed patchset #1 (id:1) manually as 6452961033268f4559aeca6a5f406899ba6c861b (presubmit successful).
5 years, 7 months ago (2015-05-21 21:05:42 UTC) #3
Bill Hesse
lgtm https://codereview.chromium.org/1157463003/diff/1/tests/html/html.status File tests/html/html.status (right): https://codereview.chromium.org/1157463003/diff/1/tests/html/html.status#newcode105 tests/html/html.status:105: #element_animate_test/omit_timing: Skip # Timing out inexplicably. Temporarily suppressing ...
5 years, 7 months ago (2015-05-22 07:30:12 UTC) #4
Bill Hesse
https://codereview.chromium.org/1157463003/diff/1/tests/html/html.status File tests/html/html.status (right): https://codereview.chromium.org/1157463003/diff/1/tests/html/html.status#newcode106 tests/html/html.status:106: #element_animate_test/timing_dict: Skip # Timing out inexplicably. Temporarily suppressing (alanknight) ...
5 years, 7 months ago (2015-05-22 11:19:32 UTC) #5
Alan Knight
5 years, 7 months ago (2015-05-22 16:42:12 UTC) #6
Message was sent while issue was closed.
Actually that wasn't what I was doing. Those tests had stopped working at least
in part because Chrome had stopped making the changing CSS attribute values
visible and that was what they relied on. Ones marked as fail had started
working again. But it seems there's something more going on with those two. I
thought they were passing for me, but it looks like they're passing but then not
cleanly terminating. I'll investigate further. Thanks.

Powered by Google App Engine
This is Rietveld 408576698