Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1157433014: Don't crash when reporting an error (Closed)

Created:
5 years, 6 months ago by Siggi Cherem (dart-lang)
Modified:
5 years, 6 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Siggi Cherem (dart-lang)
This is to partially address the issue in https://github.com/dart-lang/sdk/issues/23599 It doesn't make the error entirely ...
5 years, 6 months ago (2015-06-05 22:41:32 UTC) #2
Johnni Winther
lgtm
5 years, 6 months ago (2015-06-07 08:35:20 UTC) #3
Siggi Cherem (dart-lang)
5 years, 6 months ago (2015-06-08 20:01:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e20001a07fd72d3bcebb34875771a42b3f6d2a70 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698