Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 1157363002: Don't promote the eclipse plugins, we don't ship these from our main repo (Closed)

Created:
5 years, 6 months ago by ricow1
Modified:
5 years, 6 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't promote the eclipse plugins, we don't ship these from our main repo Also, change the sanity check, we no longer use integer revisions on dev/stable R=whesse@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/1706e033afbb7b1337c848ad90c70b21e979b44f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M tools/promote.py View 3 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ricow1
5 years, 6 months ago (2015-05-28 12:34:30 UTC) #1
Bill Hesse
lgtm
5 years, 6 months ago (2015-05-28 13:04:23 UTC) #2
ricow1
5 years, 6 months ago (2015-05-28 14:02:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1706e033afbb7b1337c848ad90c70b21e979b44f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698