Issue 11573063: Revert "Clean up the patch file for the isolate library by introducing a new builtin library: isola…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11573063: Revert "Clean up the patch file for the isolate library by introducing a new builtin library: isola… (Closed)

Created:
8 years ago by Johnni Winther

Modified:
8 years ago

Reviewers:
ricow1, ngeoffray

CC:
reviews_dartlang.org, ngeoffray

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert "Clean up the patch file for the isolate library by introducing a new builtin library: isolate_helper.dart." This reverts commit r16029. BUG=http://dartbug.com/7448 Committed: https://code.google.com/p/dart/source/detail?r=16250

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1284 lines, -1346 lines)			Patch
M	runtime/lib/isolate_patch.dart	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/compiler.dart	View	4 chunks	+6 lines, -27 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/elements/elements.dart	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
D	sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart	View	1 chunk	+0 lines, -1283 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/isolate_patch.dart	View	1 chunk	+1263 lines, -13 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/native_handler.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/libraries.dart	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	sdk/lib/isolate/timer.dart	View	1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

8 years ago (2012-12-18 12:34:24 UTC) #4

Message was sent while issue was closed.

On 2012/12/18 12:27:37, ngeoffray wrote:
> LGTM. Did you use git bisect to find the offending CL?

No. I used git blame on isolate_helper.

Expand Messages | Collapse Messages