Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 11571056: Set close-on-exec flag on pipe() and kqueue() file descriptors on MacOS (Closed)

Created:
8 years ago by kustermann
Modified:
8 years ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Set close-on-exec flag on pipe() and kqueue() file descriptors on MacOS Committed: https://code.google.com/p/dart/source/detail?r=16316

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M runtime/bin/eventhandler_macos.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M runtime/bin/process_macos.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kustermann
Seems to work on MacOS as well.
8 years ago (2012-12-19 10:42:15 UTC) #1
Mads Ager (google)
LGTM
8 years ago (2012-12-19 10:51:15 UTC) #2
Søren Gjesse
8 years ago (2012-12-19 12:06:49 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698