Tests which fail on Opera are now marked as "Fail", with comment "to be triaged"

Tests which fail on Opera are now marked as "Fail", with comment "to be triaged"

Committed: https://code.google.com/p/dart/source/detail?r=16125

[ricow1, 2012-12-13 16:06:09]

LGTM if you remove the test suite prefix directories

https://codereview.chromium.org/11571009/diff/2001/tests/corelib/corelib.status
File tests/corelib/corelib.status (right):

https://codereview.chromium.org/11571009/diff/2001/tests/corelib/corelib.stat...
tests/corelib/corelib.status:23: corelib/null_nosuchmethod_test: Fail #
TODO(ahe): Please triage this failure.
don't prefix with corelib/

https://codereview.chromium.org/11571009/diff/2001/tests/html/html.status
File tests/html/html.status (right):

https://codereview.chromium.org/11571009/diff/2001/tests/html/html.status#new...
tests/html/html.status:215: html/keyboard_event_test: Fail # TODO(ahe): Please
triage this failure.
I don't think you should prefix this and the 3 below with html/

https://codereview.chromium.org/11571009/diff/2001/tests/language/language_da...
File tests/language/language_dart2js.status (right):

https://codereview.chromium.org/11571009/diff/2001/tests/language/language_da...
tests/language/language_dart2js.status:363:
language/string_interpolate_null_test: Fail # TODO(ahe): Please triage this
failure.
don't prefix with language

[kustermann, 2012-12-13 16:12:42]

https://codereview.chromium.org/11571009/diff/2001/tests/corelib/corelib.status
File tests/corelib/corelib.status (right):

https://codereview.chromium.org/11571009/diff/2001/tests/corelib/corelib.stat...
tests/corelib/corelib.status:23: corelib/null_nosuchmethod_test: Fail #
TODO(ahe): Please triage this failure.
On 2012/12/13 16:06:10, ricow1 wrote:
> don't prefix with corelib/

Done.

https://codereview.chromium.org/11571009/diff/2001/tests/html/html.status
File tests/html/html.status (right):

https://codereview.chromium.org/11571009/diff/2001/tests/html/html.status#new...
tests/html/html.status:215: html/keyboard_event_test: Fail # TODO(ahe): Please
triage this failure.
On 2012/12/13 16:06:10, ricow1 wrote:
> I don't think you should prefix this and the 3 below with html/

Done.

https://codereview.chromium.org/11571009/diff/2001/tests/language/language_da...
File tests/language/language_dart2js.status (right):

https://codereview.chromium.org/11571009/diff/2001/tests/language/language_da...
tests/language/language_dart2js.status:363:
language/string_interpolate_null_test: Fail # TODO(ahe): Please triage this
failure.
On 2012/12/13 16:06:10, ricow1 wrote:
> don't prefix with language

Done.

[ahe, 2012-12-14 08:35:42]

LGTM, but I'd prefer if you stop adding todo for me :-)

[kustermann, 2012-12-14 08:56:20]

On 2012/12/14 08:35:42, ahe wrote:
> LGTM, but I'd prefer if you stop adding todo for me :-)

Actually I'm feeling bad about this. But it seems like it is our responsibility
to get safari/opera eventually back to the main waterfall -- and one step in
that direction is making them green on FYI. (I could have used 'Needs to be
triaged'?)

[ahe, 2012-12-14 08:59:56]

On 2012/12/14 08:56:20, kustermann wrote:
> On 2012/12/14 08:35:42, ahe wrote:
> > LGTM, but I'd prefer if you stop adding todo for me :-)
> 
> Actually I'm feeling bad about this. But it seems like it is our
responsibility
> to get safari/opera eventually back to the main waterfall -- and one step in
> that direction is making them green on FYI. (I could have used 'Needs to be
> triaged'?)

Perhaps you could file a bug that states something like "Many tests are failing
on Safari" and just list all the bugs there.   This would be area-dart2js, and
something that the dart2js team would allocate resources to deal with.  Getting
Safari to not flake is a different matter than fixing bugs in dart2js.