Issue 11570042: Implement InvocationMirror.invokeOn method in the vm (issue 7227).

Issue 11570042: Implement InvocationMirror.invokeOn method in the vm (issue 7227). (Closed)

Created:
8 years ago by regis

Modified:
8 years ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Implement InvocationMirror.invokeOn method in the vm (issue 7227). Committed: https://code.google.com/p/dart/source/detail?r=16187

Patch Set 2 : #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+269 lines, -52 lines)			Patch
A	runtime/lib/invocation_mirror.cc	View		1 chunk	+129 lines, -0 lines	0 comments	Download
M	runtime/lib/invocation_mirror_patch.dart	View	1	1 chunk	+93 lines, -45 lines	0 comments	Download
M	runtime/lib/lib_sources.gypi	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/bootstrap_natives.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/code_generator.cc	View	1	3 chunks	+7 lines, -7 lines	0 comments	Download
A	tests/language/invocation_mirror_invoke_on_test.dart	View		1 chunk	+37 lines, -0 lines	0 comments	Download
M	tests/language/language_dart2js.status	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM https://codereview.chromium.org/11570042/diff/1/runtime/lib/invocation_mirror_patch.dart File runtime/lib/invocation_mirror_patch.dart (right): https://codereview.chromium.org/11570042/diff/1/runtime/lib/invocation_mirror_patch.dart#newcode74 runtime/lib/invocation_mirror_patch.dart:74: if (_memberName == null) { Check _type == ...

8 years ago (2012-12-15 00:20:17 UTC) #2

regis

Thanks! https://codereview.chromium.org/11570042/diff/1/runtime/lib/invocation_mirror_patch.dart File runtime/lib/invocation_mirror_patch.dart (right): https://codereview.chromium.org/11570042/diff/1/runtime/lib/invocation_mirror_patch.dart#newcode74 runtime/lib/invocation_mirror_patch.dart:74: if (_memberName == null) { On 2012/12/15 00:20:17, ...

8 years ago (2012-12-15 00:23:22 UTC) #3

regis

8 years ago (2012-12-15 03:35:31 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/11570042/diff/1/runtime/lib/invocation_mirror...
File runtime/lib/invocation_mirror_patch.dart (right):

https://codereview.chromium.org/11570042/diff/1/runtime/lib/invocation_mirror...
runtime/lib/invocation_mirror_patch.dart:74: if (_memberName == null) {
On 2012/12/15 00:23:22, regis wrote:
> On 2012/12/15 00:20:17, srdjan wrote:
> > Check _type == NULL
> 
> Changed to _type == null

I realized as I was driving home that I submitted without making this change.
I'll do it on Monday. Promised.

Expand Messages | Collapse Messages