Fix argument processing for RandomAccessFile.writeFrom

Fix argument processing for RandomAccessFile.writeFrom

It is now the same as for RandomAccessFile.writeFromSync

Added some tests.

R=lrn@google.com
BUG=http://dartbug.com/23521

Committed: https://github.com/dart-lang/sdk/commit/897d05b6f0a80c7ba6933a059018184b724f5316

[Lasse Reichstein Nielsen, 2015-05-26 11:20:12]

https://codereview.chromium.org/1156993003/diff/20001/sdk/lib/io/file_impl.dart
File sdk/lib/io/file_impl.dart (right):

https://codereview.chromium.org/1156993003/diff/20001/sdk/lib/io/file_impl.da...
sdk/lib/io/file_impl.dart:359: return
_IOService._dispatch(_FILE_LENGTH_FROM_PATH, [path]).then((response) {
While you are here: Long line?

https://codereview.chromium.org/1156993003/diff/20001/sdk/lib/io/file_impl.da...
sdk/lib/io/file_impl.dart:775: if (start == null) start = 0;
Why not just make 0 the default value for the `start` parameter directly, as we
do everywhere else?

Then you probably want to just do:
  
  end = RangeError.checkValidRange(start, end, this);
  if (start == end) return;

as the entire prelude of the function.

In other words, drop the _checkReadWriteListArguments function, and don't do the
end = buffer.length manually (it's done in RangeError.checkValidRange too).

[Søren Gjesse, 2015-05-26 14:51:15]

Thanks Lasse, PTAL

https://codereview.chromium.org/1156993003/diff/20001/sdk/lib/io/file_impl.dart
File sdk/lib/io/file_impl.dart (right):

https://codereview.chromium.org/1156993003/diff/20001/sdk/lib/io/file_impl.da...
sdk/lib/io/file_impl.dart:359: return
_IOService._dispatch(_FILE_LENGTH_FROM_PATH, [path]).then((response) {
On 2015/05/26 11:20:12, Lasse Reichstein Nielsen wrote:
> While you are here: Long line?

Done.

https://codereview.chromium.org/1156993003/diff/20001/sdk/lib/io/file_impl.da...
sdk/lib/io/file_impl.dart:775: if (start == null) start = 0;
On 2015/05/26 11:20:12, Lasse Reichstein Nielsen wrote:
> Why not just make 0 the default value for the `start` parameter directly, as
we
> do everywhere else?
> 
> Then you probably want to just do:
>   
>   end = RangeError.checkValidRange(start, end, this);
>   if (start == end) return;
> 
> as the entire prelude of the function.
> 
> In other words, drop the _checkReadWriteListArguments function, and don't do
the
> end = buffer.length manually (it's done in RangeError.checkValidRange too).

Done. _checkReadWriteListArguments actually just called
RangeError.checkValidRange

Fixed for readInto and readIntoSync as well.

[Lasse Reichstein Nielsen, 2015-05-26 19:48:40]

lgtm

https://codereview.chromium.org/1156993003/diff/40001/sdk/lib/io/file_impl.dart
File sdk/lib/io/file_impl.dart (right):

https://codereview.chromium.org/1156993003/diff/40001/sdk/lib/io/file_impl.da...
sdk/lib/io/file_impl.dart:767: if ((buffer is !List && buffer is !ByteData) ||
Still checking for ByteData which isn't a List.

[Søren Gjesse, 2015-05-27 08:01:29]

Committed patchset #4 (id:60001) manually as
897d05b6f0a80c7ba6933a059018184b724f5316 (presubmit successful).