Improve error for non-const implicit super constructor

Improve error for non-const implicit super constructor

BUG= http://dartbug.com/23543
R=johnniwinther@google.com

Committed: https://github.com/dart-lang/sdk/commit/7e2dc9eb2aecde0f656ea76830eac089c994d240

[Siggi Cherem (dart-lang), 2015-05-29 01:41:36]

sigmund@google.com changed reviewers:
+ johnniwinther@google.com

[Johnni Winther, 2015-05-29 08:24:04]

lgtm

https://codereview.chromium.org/1156923007/diff/1/pkg/compiler/lib/src/warnin...
File pkg/compiler/lib/src/warnings.dart (right):

https://codereview.chromium.org/1156923007/diff/1/pkg/compiler/lib/src/warnin...
pkg/compiler/lib/src/warnings.dart:487: "super non-const constructor.",
The wording makes it sound like the constructor (and not the call) is implicit.

https://codereview.chromium.org/1156923007/diff/1/pkg/compiler/lib/src/warnin...
pkg/compiler/lib/src/warnings.dart:488: howToFix: "Try making the super
constructor const",
'const' -> 'const.'

[Siggi Cherem (dart-lang), 2015-05-29 16:09:34]

thx

https://codereview.chromium.org/1156923007/diff/1/pkg/compiler/lib/src/warnin...
File pkg/compiler/lib/src/warnings.dart (right):

https://codereview.chromium.org/1156923007/diff/1/pkg/compiler/lib/src/warnin...
pkg/compiler/lib/src/warnings.dart:487: "super non-const constructor.",
On 2015/05/29 08:24:04, Johnni Winther wrote:
> The wording makes it sound like the constructor (and not the call) is
implicit.

Good point. Rephrased.

https://codereview.chromium.org/1156923007/diff/1/pkg/compiler/lib/src/warnin...
pkg/compiler/lib/src/warnings.dart:488: howToFix: "Try making the super
constructor const",
On 2015/05/29 08:24:04, Johnni Winther wrote:
> 'const' -> 'const.'

Done.

[Siggi Cherem (dart-lang), 2015-05-29 16:24:06]

Committed patchset #1 (id:1) manually as
7e2dc9eb2aecde0f656ea76830eac089c994d240 (presubmit successful).