Issue 11567010: Complete the transition to unicode APIs on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11567010: Complete the transition to unicode APIs on Windows. (Closed)

Created:
8 years ago by Mads Ager (google)

Modified:
8 years ago

Reviewers:
Søren Gjesse, Anton Muhin

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Complete the transition to unicode APIs on Windows. Define _UNICODE and UNICODE so that we do not add accidental dependencies on non-unicode APIs. Anton, this could have an influence on Dartium builds as well? R=sgjesse@google.com,antonm@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=16104

Patch Set 1 #

Total comments: 1

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+60 lines, -51 lines)			Patch
M	runtime/bin/extensions_win.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	runtime/bin/process_win.cc	View	7 chunks	+40 lines, -39 lines	0 comments	Download
M	runtime/bin/socket_win.cc	View	2 chunks	+14 lines, -10 lines	0 comments	Download
M	runtime/platform/globals.h	View	1 chunk	+2 lines, -1 line	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

LGTM! https://codereview.chromium.org/11567010/diff/1/runtime/platform/globals.h File runtime/platform/globals.h (right): https://codereview.chromium.org/11567010/diff/1/runtime/platform/globals.h#newcode24 runtime/platform/globals.h:24: #define UNICODE UNICODE ftw!

8 years ago (2012-12-13 12:40:28 UTC) #2

Anton Muhin

Hopefully not as you only change stuff in dart VM standalone, correct?

8 years ago (2012-12-13 13:02:00 UTC) #3

Mads Ager (google)

8 years ago (2012-12-13 14:10:33 UTC) #4

Message was sent while issue was closed.

I think I have changed all the API usages in the VM library as well. So maybe we
can remove the undef of UNICODE in the dartium build. However, I had to revert
this, so we have to wait a bit while I investigate. :-)

Expand Messages | Collapse Messages