Issue 11567009: Implement InterfaceType.asInstanceOf.

Issue 11567009: Implement InterfaceType.asInstanceOf. (Closed)

Created:
8 years ago by karlklose

Modified:
7 years, 11 months ago

Reviewers:
Johnni Winther, ahe

CC:
reviews_dartlang.org, Johnni Winther

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Implement InterfaceType.asInstanceOf. Committed: https://code.google.com/p/dart/source/detail?r=17454

Patch Set 2 : #

Total comments: 4

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+154 lines, -76 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/typechecker.dart	View	1	6 chunks	+67 lines, -46 lines	4 comments	Download
	M	tests/compiler/dart2js/type_substitution_test.dart	View	1	3 chunks	+87 lines, -30 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

https://codereview.chromium.org/11567009/diff/2002/sdk/lib/_internal/compiler/implementation/typechecker.dart File sdk/lib/_internal/compiler/implementation/typechecker.dart (right): https://codereview.chromium.org/11567009/diff/2002/sdk/lib/_internal/compiler/implementation/typechecker.dart#newcode664 sdk/lib/_internal/compiler/implementation/typechecker.dart:664: static Link<DartType> substTypes(Link<DartType> types, Was this method changed? If ...

8 years ago (2012-12-14 08:00:19 UTC) #3

karlklose

7 years, 11 months ago (2013-01-08 14:01:43 UTC) #4

https://codereview.chromium.org/11567009/diff/2002/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/typechecker.dart (right):

https://codereview.chromium.org/11567009/diff/2002/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/typechecker.dart:664: static
Link<DartType> substTypes(Link<DartType> types,
It is unchanged. I moved this method from a top-level method imported into
dart2js to the Types class to group it with the rest of the type related
helpers. Do you prefer to leave it as a toplevel method?

https://codereview.chromium.org/11567009/diff/2002/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/typechecker.dart:688: static String
fetchReasonsFromMalformedType(DartType type) {
Not changed. See above for the reason to move it.

Expand Messages | Collapse Messages