Issue 1156663002: Escape arguments in pub error message command line reproduction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1156663002: Escape arguments in pub error message command line reproduction. (Closed)

Created:
5 years, 7 months ago by Bill Hesse

Modified:
5 years, 6 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Escape arguments in pub error message command line reproduction. BUG=dartbug.com/23505 Rebase of https://codereview.chromium.org/1035853003/ R=nweiz@google.com Committed: https://github.com/dart-lang/sdk/commit/fc1bb66b888b3b1b1e9aaa4cf143fdca20f301cb

Patch Set 1 #

Total comments: 1

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	sdk/lib/_internal/pub/lib/src/command_runner.dart	View		1 chunk	+3 lines, -1 line	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Bill Hesse

This addresses the comments on the preceding CL review. This new CL rebases onto the ...

5 years, 7 months ago (2015-05-22 08:02:05 UTC) #2

nweiz

lgtm https://codereview.chromium.org/1156663002/diff/1/sdk/lib/_internal/pub/lib/src/command_runner.dart File sdk/lib/_internal/pub/lib/src/command_runner.dart (right): https://codereview.chromium.org/1156663002/diff/1/sdk/lib/_internal/pub/lib/src/command_runner.dart#newcode134 sdk/lib/_internal/pub/lib/src/command_runner.dart:134: protectArgument(String x) => x.contains(' ') ? '"$x"' : ...

5 years, 7 months ago (2015-05-22 20:01:34 UTC) #3

Bill Hesse

5 years, 6 months ago (2015-05-27 15:21:55 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
fc1bb66b888b3b1b1e9aaa4cf143fdca20f301cb (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages