Issue 1156583005: Fix isAssignableTo in VM mirrors to use subtype (<:) rather than moreSpecificThan (<<).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1156583005: Fix isAssignableTo in VM mirrors to use subtype (<:) rather than moreSpecificThan (<<). (Closed)

Created:
5 years, 6 months ago by rmacnak

Modified:
5 years, 6 months ago

Reviewers:
gbracha

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix isAssignableTo in VM mirrors to use subtype (<:) rather than moreSpecificThan (<<). BUG=http://dartbug.com/22852 R=gbracha@google.com Committed: https://github.com/dart-lang/sdk/commit/6545e8539e5e100d4b1497c02f3647abc85bc06a

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -16 lines)			Patch
M	runtime/lib/mirrors.cc	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	runtime/lib/mirrors_impl.dart	View		4 chunks	+6 lines, -9 lines	0 comments	Download
M	runtime/vm/bootstrap_natives.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/lib/lib.status	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

rmacnak

5 years, 6 months ago (2015-06-04 19:26:05 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
6545e8539e5e100d4b1497c02f3647abc85bc06a (presubmit successful).